Use filename completer for all shell commands #12624
Conversation
Previously only :sh used the filename completer
|
It looks like this isn't going to be all that useful after #12527, because shell commands will only have one argument for autocomplete (I think) and file completion isn't going to help you pick a command to run |
|
I have partially pulled this into #12527 - all shell commands use a constant for their completer and signature. Shell command completion needs some improvements aside from #12527 though and #12527 will be (in many cases) a regression for shell command completion. Completion in general should be refactored to follow Kakoune: be a function of the current cursor position rather than argument text. That will allow some custom pasing rules for filenames that looks back and tries to find the current filename, unrelated to how the arguments are parsed. |
Previously only :sh used the filename completer
I looked at the PRs that introduced the other shell commands (#1972, #2589, #4931), and didn't see any discussion about completers so I think this is just an oversight. It's possible that I missed a shell command I didn't know about so please check for that in the review.